-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email field to the organization serializer #2647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
changed the title
Add email field to the organization serializer
[WIP]Add email field to the organization serializer
Jul 22, 2024
FrankApiyo
force-pushed
the
update-organization-serializer
branch
2 times, most recently
from
July 25, 2024 13:00
498eb89
to
18c904e
Compare
FrankApiyo
changed the title
[WIP]Add email field to the organization serializer
Add email field to the organization serializer
Jul 25, 2024
ukanga
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some tests to ensure we do not have emails exposed on public org profiles unless only to the owner of the organisation?
Co-authored-by: Kelvin Muchiri <[email protected]>
FrankApiyo
force-pushed
the
update-organization-serializer
branch
from
July 26, 2024 08:42
bb5f539
to
c6dae54
Compare
FrankApiyo
force-pushed
the
update-organization-serializer
branch
from
July 26, 2024 08:55
c6dae54
to
a098af0
Compare
kelvin-muchiri
approved these changes
Jul 26, 2024
ukanga
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add email to the organization profile model & organization serializer
Steps taken to verify this change does what is intended
Updated test cases
Before submitting this PR for review, please make sure you have:
Closes #2652