Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email field to the organization serializer #2647

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

FrankApiyo
Copy link
Member

@FrankApiyo FrankApiyo commented Jul 22, 2024

Changes / Features implemented

Add email to the organization profile model & organization serializer

Steps taken to verify this change does what is intended

Updated test cases

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2652

@FrankApiyo FrankApiyo changed the title Add email field to the organization serializer [WIP]Add email field to the organization serializer Jul 22, 2024
@FrankApiyo FrankApiyo force-pushed the update-organization-serializer branch 2 times, most recently from 498eb89 to 18c904e Compare July 25, 2024 13:00
@FrankApiyo FrankApiyo changed the title [WIP]Add email field to the organization serializer Add email field to the organization serializer Jul 25, 2024
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some tests to ensure we do not have emails exposed on public org profiles unless only to the owner of the organisation?

@FrankApiyo FrankApiyo force-pushed the update-organization-serializer branch from bb5f539 to c6dae54 Compare July 26, 2024 08:42
@FrankApiyo FrankApiyo force-pushed the update-organization-serializer branch from c6dae54 to a098af0 Compare July 26, 2024 08:55
@FrankApiyo FrankApiyo requested a review from ukanga July 26, 2024 09:10
@FrankApiyo FrankApiyo merged commit 1b6fb36 into main Jul 26, 2024
10 checks passed
@FrankApiyo FrankApiyo deleted the update-organization-serializer branch July 26, 2024 12:45
@FrankApiyo FrankApiyo mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting email when creating organization profiles does not work correctly
3 participants